Add support for tc.host in ~/.testcontainers.properties#38
Add support for tc.host in ~/.testcontainers.properties#38eddumelendez wants to merge 1 commit intomainfrom
Conversation
eddumelendez
commented
Feb 16, 2024
- Support tc.host
Read `tc.host` property from `~/.testcontainers.properties` file.
|
Is the The |
|
I think we should support both |
Great! @guilleiguaran LMK once it is available and I can rework the PR.
|
While not currently an env var, I think it would be useful to be able to use it. For example, instead of: tc_host = properties.get(:"tc.host")We could have: tc_host = ENV["TESTCONTAINERS_HOST"] || properties.get(:"tc.host")Or swap the order of the two depending on which value you'd like to take precedence. Let me know what you think! :) |
|
Thanks for the feedback and sorry for not providing the context when submitting the PR. The support for I think what is related to the goal of the discussion here, is supporting |
|
Hi @guilleiguaran, any update to support reading properties files? |
|
Hey Guys, I hope you're doing well In this PR I pretended to add support to ~/.tescontainers.properties files but using Java Properties https://github.com/jnbt/java-properties Let me know if this is a good option for you Posdata: the pipeline is broken because an specific error trying to pooling the version 3.3.0-rc1: Error: Error: Unavailable version 3.3.0-rc1 for ruby on ubuntu-24.04 |
|
Reviewed and merged #81 |